Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve language when doing client-side failover #186

Merged
merged 7 commits into from
Feb 12, 2016
Merged

Conversation

matteofigus
Copy link
Member

When making server-side request with a client, if a failover mechanism is in place the url won't preserve the original accept-language header.

With this option (needed only if components depend on Accept-Language) the client adds a __ocAcceptLanguage parameter with the original Accept-Language value. The framework, when receiving that parameter, will ignore the Accept-Language header and will use that parameter instead.

@matteofigus
Copy link
Member Author

Anyone could do a review? Perhaps @antwhite or @lukasz-lysik or @andyroyle?

@antwhite
Copy link
Collaborator

@matteofigus LGTM (it works for my components)

@matteofigus
Copy link
Member Author

Thanks @antwhite, can you merge? I'll publish. Thanks

antwhite added a commit that referenced this pull request Feb 12, 2016
Preserve language when doing client-side failover
@antwhite antwhite merged commit 08836da into master Feb 12, 2016
@matteofigus matteofigus deleted the preserve-language branch February 12, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants