Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 validation #214

Merged
merged 3 commits into from
Mar 23, 2016
Merged

S3 validation #214

merged 3 commits into from
Mar 23, 2016

Conversation

matteofigus
Copy link
Member

Fixes #162

jankowiakmaria
jankowiakmaria reviewed Mar 22, 2016
View reviewed changes
test/unit/registry-domain-validator.js
});
});

describe('when s3 setting is missing bucket', function(){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteofigus isn't this test the same as the one above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Fixed it.

@jankowiakmaria
Copy link
Collaborator

👍
btw @matteofigus do you mind if we start using rebase instead of merge? It makes history much cleaner (no commits like Merge branch 'master' of...).

@jankowiakmaria jankowiakmaria merged commit 5427ad1 into master Mar 23, 2016
@jankowiakmaria jankowiakmaria deleted the s3-validation branch March 23, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @jankowiakmaria