throwing exception when registry is initialised with invalid conf #25 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| "newcap" : false, // true: Require capitalization of all constructor functions e.g. `new F()` | |||
| "noarg" : true, // true: Prohibit use of `arguments.caller` and `arguments.callee` | |||
| "noempty" : true, // true: Prohibit use of empty blocks | |||
| "nonew" : true, // true: Prohibit use of constructors for side-effects (without assignment) | |||
| "nonew" : false, // true: Prohibit use of constructors for side-effects (without assignment) | |||
There was a problem hiding this comment.
https://jslinterrors.com/do-not-use-new-for-side-effects
lint was not allowing me to write new oc.Registry(args); without assigning to a variable.
There was a problem hiding this comment.
can't you assign a variable there?
|
Can you remove if(registry.err){
return console.log(registry.err);
}from the README too? Thanks! |
|
README done, looking if I can find a way not to change .jshintrc |
matteofigus
added a commit
that referenced
this pull request
Feb 12, 2015
throwing exception when registry is initialised with invalid conf #25
|
yeah, looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #25