Recursively look for oc.json, starting from componentsDir #313
Conversation
matteofigus
changed the title
There was a problem hiding this comment.
I assume that all the tests are green but as per my comment you added a optional parameter to the public API so I think you should add tests when you call the method w/ the componentsDir parameter
over to you @matteofigus
| @@ -25,11 +25,12 @@ var registerStaticMocks = function(mocks, logger){ | |||
| }); | |||
| }; | |||
|
|
|||
| var registerDynamicMocks = function(mocks, logger){ | |||
| var registerDynamicMocks = function(mocks, ocJsonPath, logger){ | |||
There was a problem hiding this comment.
I think you should rename this parameter into ocJsonLocation as per the way you invoke the method below in line 97
| }; | ||
|
|
||
| module.exports = function(logger, componentsDir){ | ||
| componentsDir = path.resolve(componentsDir || '.'); |
There was a problem hiding this comment.
so if you do not pass the componentsDir parameter you set it to '. correct?
| describe('when oc.json is missing', function(){ | ||
| var result; | ||
| beforeEach(function(){ | ||
| initialise({ existsSync: sinon.stub().returns(false) }); | ||
| result = getMockedPlugins(console); | ||
| result = getMockedPlugins(console, '/root/components/'); |
There was a problem hiding this comment.
I see that now all the tests are passing the path parameter to the getMockedPlugins method; I think we should have tests w/o the second parameter as well what do you think?
| if(!content.mocks || !content.mocks.plugins){ | ||
| return plugins; | ||
| } | ||
|
|
||
| logger.log(colors.yellow(strings.messages.cli.REGISTERING_MOCKED_PLUGINS)); | ||
|
|
||
| plugins = plugins.concat(registerStaticMocks(content.mocks.plugins.static, logger)); | ||
| plugins = plugins.concat(registerDynamicMocks(content.mocks.plugins.dynamic, logger)); | ||
| plugins = plugins.concat(registerDynamicMocks(content.mocks.plugins.dynamic, ocJsonLocation, logger)); |
There was a problem hiding this comment.
I am also thinking about preserve the same "pattern" between the methods (registerStaticMocks and registerDynamicMocks) such as adding the extra parameter either at the very beginning or after "logger" but not in between 😅
registerDynamicMocks(ocJsonLocation, content.mocks.plugins.dynamic, logger)
or
registerDynamicMocks(content.mocks.plugins.dynamic, logger, ocJsonLocation)
|
LGTM 👍 (squashmerge) |
Fixes #219