Add optional cache headers for components (#325) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a function setHeader(name, value) to the context object that we pass to the component data function. * Subsequently these headers (if added) will be set in the response data in the returned component JSON as well as response headers (component.js) * Added a mock component (response-headers-component) and a test to cover the new functionality
|
Awesome stuff @ivan-dimitrov-skyscanner, thanks for the PR! |
i-b-dimitrov
added a commit
to i-b-dimitrov/oc
that referenced
this pull request
Dec 9, 2016
The problem was introduced with opencomponents#326 - In get-component.js the declaration of responseHeaders var happens in a more global scope than it should be. For this reason every invocation of renderer function sees the changes in the headers made by previously requested components. The fix is to just move the declaration one scope inner. - Added a unit test to validate the fix - it tries to load two components subsequently. The first one does provide custom headers while the second one - don't. Then we check and expect to see there are no custom headers in the result for the second one.
i-b-dimitrov
added a commit
to i-b-dimitrov/oc
that referenced
this pull request
Dec 9, 2016
The problem was introduced with opencomponents#326 - In get-component.js the declaration of responseHeaders variable happens in a more global scope than it should be. For this reason every invocation of renderer function sees the changes in the headers made by previously requested components. The fix is to just move the declaration one scope inner. - Added a unit test to validate the fix - it tries to load two components subsequently. The first one does provide custom headers while the second one - don't. Then we check and expect to see there are no custom headers in the result for the second one.
matteofigus
pushed a commit
that referenced
this pull request
Dec 9, 2016
The problem was introduced with #326 - In get-component.js the declaration of responseHeaders variable happens in a more global scope than it should be. For this reason every invocation of renderer function sees the changes in the headers made by previously requested components. The fix is to just move the declaration one scope inner. - Added a unit test to validate the fix - it tries to load two components subsequently. The first one does provide custom headers while the second one - don't. Then we check and expect to see there are no custom headers in the result for the second one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function setHeader(name, value) to the context object that we pass to the component data function.
Subsequently these headers (if added) will be set in the response data for the returned component JSON as well as normal HTTP response headers (component.js)
Added a mock component (response-headers-component) and a test to cover the new functionality