Acceptance extra test #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great shout 👍 |
mattiaerre
reviewed
Dec 21, 2016
| @@ -0,0 +1,3 @@ | |||
| _package | |||
| package.tar.gz | |||
| node_modules | |||
mattiaerre
reviewed
Dec 21, 2016
| callback(null, { | ||
| magicNumber: _.first([5, 4]) | ||
| }); | ||
| }; |
mattiaerre
reviewed
Dec 21, 2016
| @@ -0,0 +1 @@ | |||
| div The magic number is #{magicNumber} | |||
|
@mattiaerre as discussed I also renamed |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #323 I realised we don't have any fixture for a component that requires dependencies in the acceptance tests suite, and I thought about making a separate PR in order to add that. It should make reviewing #323 easier.
What do you think @matthewdavidson?