Extending Integration tests #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
changed the title
nickbalestra
force-pushed
the
integrationTests
branch
2 times, most recently
from
cc43773
to
5a073af
Compare
matteofigus
requested changes
Jan 21, 2017
| }); | ||
|
|
||
| it('should save compiled data provider', function(done){ | ||
| packageServerScript( |
There was a problem hiding this comment.
what if we bring all of this stuff inside the beforeEach and we save the results (compiledContent + error) into a variable, so then we can have more individual "it" (sync) tests that can explain a little bit better what we are doing?
e.g. first test we have no error, then test wrapping correctly works for do, another for the for, and another one for the while? I think it would improve readability and maintainability
nickbalestra
force-pushed
the
integrationTests
branch
from
5a073af
to
f8bb112
Compare
|
@matteofigus updated the tests, let me know what you think |
matteofigus
approved these changes
Jan 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added complex integration test to cover situations like the one reported with #358