Babili on server.js #411
Merged
Babili on server.js #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
commented
Mar 20, 2017
| @@ -43,6 +44,7 @@ module.exports = function webpackConfigGenerator(params){ | |||
| ] | |||
| }, | |||
| plugins: [ | |||
| new BabiliPlugin(), | |||
There was a problem hiding this comment.
simple integration atm
matteofigus
commented
Mar 20, 2017
| 'const sayHello = (name) => {' + | ||
| ' if(name!=="John Doe") infiniteLoops();' + | ||
| ' return `Hello ${name}`;' + | ||
| '};' + |
There was a problem hiding this comment.
I had to trick babili and its treeshaking as the previous test was just removing the infiniteLoops() function as it had no calls (and therefore not making the infinite loops replacements).
matteofigus
commented
Mar 20, 2017
| expect(compiledContent).to.contain('var __ITER = 1000000000;do { if(__ITER <=0){ throw new Error' + | ||
| '("Loop exceeded maximum allowed iterations"); } \n' + | ||
| ' z = 342;\n __ITER--; } while (true);'); | ||
| expect(compiledContent.match(/Loop exceeded maximum allowed iterations/g).length).to.equal(3); |
There was a problem hiding this comment.
Here it became complicated to test the exact replacement as it gets minified after that. In any case, I test that there are 3 replacements containing that string, which is the number of loops I expect. Good enough, I guess 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't include (yet) the sourcemaps for server.js.
/cc @nickbalestra