Async compile api #412
Merged
Async compile api #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
reviewed
Mar 21, 2017
src/cli/domain/package-template.js
Outdated
| var compiledView = templateEngines[type].compile(template, { viewPath }), | ||
| hashView = hashBuilder.fromString(compiledView.toString()), | ||
| javaScriptizedView = javaScriptizeTemplate(hashView, compiledView); | ||
| var compiledView = templateEngines[type].compile({ template, viewPath }, compiledView => { |
There was a problem hiding this comment.
=> are still currently illegal according to jshint styleguide. While we upgrade to ES6, can you switch this statement to ES5?
nickbalestra
force-pushed
the
async-compile-api
branch
5 times, most recently
from
e646dc9
to
c2900da
Compare
nickbalestra
force-pushed
the
async-compile-api
branch
from
c2900da
to
a4c0b87
Compare
matteofigus
requested changes
Mar 21, 2017
|
@matteofigus should be done, let me know if anything :) |
matteofigus
approved these changes
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependent upon deployment of
This PR, allow for the new async signature of the template API so that it can accomodate bundling and other async stuff