New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require templates is broken #444

Merged

federicomaffei merged 1 commit into master from require-templates-fix

Apr 6, 2017

Member

matteofigus commented Apr 6, 2017 •

edited

Loading

@nickbalestra I believe this was introduced in one of the recent PRs.

{
  code: "INTERNAL_SERVER_ERROR",
  error: "Error requiring oc-template: "oc-template-jade" not found",
  name: "xxxxx",
  requestVersion: "xxxxx"
}

Actions:

I noticed that the repository calls the require-template (which has expensive stuff like the deletes and the require stuff with the cache invalidation) on each component execution. I think the deal was to do it only on registry start - so we may need to double check that
How was this not catched by any test? We need to definitely improve testing before releasing the next version (all the latest PRs about templating are un-released)


          Require templates is broken

52891dd

Contributor

nickbalestra commented Apr 6, 2017

👍 LGTM
Let's follow-up with PRs for 1 & 2

federicomaffei merged commit 67c6958 into master

matteofigus deleted the require-templates-fix branch

April 6, 2017 15:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet