Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #458

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Cleanup #458

merged 2 commits into from
Apr 11, 2017

Conversation

matteofigus
Copy link
Member

  1. Included a s3.getJson convenience method including JSON parsing logic to remove duplication
  2. ES6-ify some little stuff to improve readability
  3. Moved some little things around

Recommend ?w=1 for review

federicomaffei
federicomaffei approved these changes Apr 11, 2017
View reviewed changes
Copy link
Collaborator

@federicomaffei federicomaffei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@federicomaffei federicomaffei merged commit dfd4e8c into master Apr 11, 2017
@federicomaffei federicomaffei deleted the cleanup branch April 11, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicomaffei federicomaffei federicomaffei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @federicomaffei