Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-with-amd #481

Merged
merged 1 commit into from
May 11, 2017
Merged

issue-with-amd #481

merged 1 commit into from
May 11, 2017

Conversation

mattiaerre
Copy link
Member

@mattiaerre mattiaerre commented May 10, 2017

Description

  • merge root.oc into exports
  const root = { a: 'b', c: 'd', oc: { cmd: [{ message: 'We :heart: OC' }] } };
  const exports = { e: 'f', g: 'h' };
  $.extend(exports, root.oc);

  root.oc = exports;

  console.log(JSON.stringify(root, null, 2));
{
  "a": "b",
  "c": "d",
  "oc": {
    "e": "f",
    "g": "h",
    "cmd": [
      {
        "message": "We :heart: OC"
      }
    ]
  }
}

@mattiaerre mattiaerre requested a review from matteofigus May 10, 2017 19:33
@mattiaerre
Copy link
Member Author

// cc @navamgupta

@navamgupta
Copy link

LGTM, I do not think I can approve it :)

@matteofigus
Copy link
Member

LGTM. Will merge and release tomorrow 👍

@matteofigus matteofigus merged commit 261ea23 into master May 11, 2017
@matteofigus matteofigus deleted the issue-with-amd branch May 11, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants