Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render trycatch #486

Merged
merged 4 commits into from
May 23, 2017
Merged

Render trycatch #486

merged 4 commits into from
May 23, 2017

Conversation

matteofigus
Copy link
Member

This is for making sure that if the compiled view rendering throws any exception, this is handled and the registry is able to return a proper 500 status code (instead of hanging because of the unhandled exception).

Copy link
Contributor

@jwhayes jwhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteofigus matteofigus merged commit ddfe23d into master May 23, 2017
@matteofigus matteofigus deleted the render-trycatch branch May 23, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants