Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin detective logic #530

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Remove plugin detective logic #530

merged 1 commit into from
Jul 5, 2017

Conversation

matteofigus
Copy link
Member

Fixes #529

To follow, another set of PRs to the templates in order to reintegrate the detection inside the webpack/babel packaging (as described in the issue)

Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM

@@ -422,28 +410,6 @@ module.exports = function(conf, repository) {
});
}

const usedPlugins = detective.parse(dataProcessorJs),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matteofigus matteofigus merged commit 8b1c7c1 into master Jul 5, 2017
@matteofigus matteofigus deleted the plugins branch July 5, 2017 16:19
@matteofigus matteofigus mentioned this pull request Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants