Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OC-69] Remove node client #538

Merged
merged 9 commits into from
Jul 13, 2017
Merged

[OC-69] Remove node client #538

merged 9 commits into from
Jul 13, 2017

Conversation

nickbalestra
Copy link
Contributor

@nickbalestra nickbalestra commented Jul 11, 2017 •
edited
Loading

Blocking PRs:

@nickbalestra nickbalestra removed the wip label Jul 13, 2017
matteofigus
matteofigus requested changes Jul 13, 2017
View reviewed changes
src/index.js
@@ -1,4 +1,3 @@
'use strict';

module.exports.Client = require('../client');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would keep support for this, just by exposing require('oc-client')

@matteofigus matteofigus merged commit 38d995d into master Jul 13, 2017
@matteofigus matteofigus deleted the removeNodeClient branch July 13, 2017 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteofigus matteofigus matteofigus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickbalestra @matteofigus