Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OC-103] #592

Merged
merged 2 commits into from
Aug 3, 2017
Merged

[OC-103] #592

merged 2 commits into from
Aug 3, 2017

Conversation

nickbalestra
Copy link
Contributor

This fix #591

Quick overview:

  • some packages that are not requirable (ie fbjs) directly were throwing errors when checking their installation through require(). Using require.resolve() instead address those cases.
  • some bugs when installing through npm were also fixed by updating to latest npm

@nickbalestra nickbalestra mentioned this pull request Aug 3, 2017
Closed
@matteofigus matteofigus merged commit aec6e3f into master Aug 3, 2017
@matteofigus matteofigus deleted the OC-103 branch August 3, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteofigus matteofigus matteofigus approved these changes

Assignees
No one assigned
Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when publishing to registry
2 participants
@nickbalestra @matteofigus