Issue #618 : Accessing s3 bucket over a proxy from oc-registry #619
Conversation
…tablishing a connection to s3 bucket
src/registry/domain/s3.js
Outdated
|
|
||
| module.exports = function(conf) { | ||
| const httpOptions = { timeout: conf.s3.timeout || 10000 }; | ||
| if (conf.s3.agentProxy) { | ||
| httpOptions.agent = proxy(conf.s3.agentProxy); |
There was a problem hiding this comment.
If the property would be called conf.s3.proxy I would imagine it would be consistent to assign to the httpOptions.agent the proxy(url) value, but given we called it agentProxy I thought it was part of the idea to pass the whole agent already?
I think this would be a bit better given the naming, and also to allow who's not interested to use the proxy to avoid installing the proxy-agent dependency.
What's your thoughts on that @mattiaerre @NapoleanReigns
There was a problem hiding this comment.
I completely agree with it. We shouldn't mandate the proxy-agent dependency to the user unless he is in need of it.
I will make the changes and submit soon.
|
I have incorporated the review comments and pushed the changes. |
agentProxy property defined under the registry configuration object needs to be considered while establishing a connection to S3 Bucket from oc-registry.
This will allow the user to host the oc registry over an infrastructure behind a proxy.
Thanks