[DX-185] install compiler inside each components' dir #710
Conversation
matteofigus
changed the title
| let dependency = compilerDep; | ||
| if (pkg.devDependencies[compilerDep]) { | ||
| dependency += `@${pkg.devDependencies[compilerDep]}`; | ||
| } |
There was a problem hiding this comment.
What will happen in the case of someone having something like * or a relative path ?
| fs.readJson(path.join(componentPath, 'package.json'), cb); | ||
|
|
||
| module.exports = (options, callback) => { | ||
| const { components, logger } = options; |
There was a problem hiding this comment.
Note for the future: I guess we could start to use destructuring in the signature leve for cases like this.
ie: module.exports = ({ components, logger }, callback) => { ... as i see we do this quite often
|
|
||
| const dependencies = {}; | ||
| const addDependencies = componentDependencies => | ||
| _.each(componentDependencies || {}, (version, dependency) => { |
There was a problem hiding this comment.
Lodash each already support passing in undefined for the collection item
| localTemplate, | ||
| relativeTemplate | ||
| ].forEach(pathToTry => { | ||
| ocTemplate = ocTemplate || cleanRequire(pathToTry, { justTry: true }); |
There was a problem hiding this comment.
why not using some instead of forEach so that you breakout of the loop as soon it get required? Am I missing something?
There was a problem hiding this comment.
I don't know about some. Perhaps let's do it in another PR as optimisation?
src/utils/clean-require.js
Outdated
| 'use strict'; | ||
|
|
||
| const tryRequire = require('try-require'); | ||
| const _ = require('lodash'); |
There was a problem hiding this comment.
I guess no need for lodash here?
This fixes opencomponents/oc-template-react#18