[DX-218] Expose cli to be used programmatically #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
requested changes
Oct 23, 2017
src/index.js
Outdated
| require(`./cli/facade/${cmd}.js`)(dependencies)(opts, cb); | ||
| } | ||
|
|
||
| module.exports.cli = cliCommand; |
There was a problem hiding this comment.
can we move lines 3-14 to own file inside the cli folder?
src/index.js
Outdated
| function cliCommand(cmd, options, cb) { | ||
| const dependencies = { | ||
| local: new Local(), | ||
| logger: options.logger || { log() {} } |
There was a problem hiding this comment.
the logger needs more methods: https://github.com/opentable/oc/blob/master/src/cli/logger.js#L14-L17
matteofigus
requested changes
Oct 23, 2017
src/index.js
Outdated
| @@ -1,4 +1,8 @@ | |||
| 'use strict'; | |||
|
|
|||
| const _ = require('lodash'); | |||
| const Local = require('./cli/domain/local'); | |||
There was a problem hiding this comment.
forgot about those 2 ^ ? Everything else LGTM
|
@matteofigus |
matteofigus
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441 by exposing the dev interface and allowing acceptance testing in a cleaner way