Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-221] Removing two clones #725

Merged
merged 1 commit into from
Oct 25, 2017
Merged

[DX-221] Removing two clones #725

merged 1 commit into from
Oct 25, 2017

Conversation

matteofigus
Copy link
Member

This could affect performance positively, in case of big params objects

nickbalestra
nickbalestra approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickbalestra nickbalestra merged commit 23e9c0c into master Oct 25, 2017
@nickbalestra nickbalestra deleted the clone-less branch October 25, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbalestra nickbalestra nickbalestra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @nickbalestra