fix(kas): populate rewrap audit log [backport to release/service/v0.11] #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
### Proposed Changes
1.) Populate kas rewrap audit message with attributes.
2.) Add keyID to `eventmetadata`
#### Example Nano failure
```json
{
"time": "2025-10-30T10:13:30.270403-05:00",
"level": "AUDIT",
"msg": "rewrap",
"namespace": "kas",
"audit": {
"object": {
"type": "key_object",
"id": "ff1a2fe2-a942-11f0-9751-a6a754e79d24",
"name": "",
"attributes": {
"assertions": [],
"attrs": [
"https://test.obligations/attr/test_attr_for_triggers/value/test_valu_for_trigger"
],
"permissions": []
}
},
"action": {
"type": "rewrap",
"result": "error"
},
"actor": {
"id": "031fe452-ddbb-4d36-b82f-c6b3dd4d122a",
"attributes": []
},
"eventMetaData": {
"algorithm": "ec:secp256r1",
"keyID": "e1",
"policyBinding": "",
"tdfFormat": "Nano"
},
"clientInfo": {
"userAgent": "connect-go/1.18.1 (go1.24.6)",
"platform": "kas",
"requestIP": "None"
},
"original": null,
"updated": null,
"requestID": "d56da397-3387-4a14-9955-73681e627e37",
"timestamp": "2025-10-30T10:13:30-05:00"
}
}
```
#### Example ztdf success
```json
{
"time": "2025-10-31T11:58:40.892713-05:00",
"level": "AUDIT",
"msg": "rewrap",
"namespace": "kas",
"audit": {
"object": {
"type": "key_object",
"id": "cd2f0354-a942-11f0-b197-a6a754e79d24",
"name": "",
"attributes": {
"assertions": [],
"attrs": [
"https://test.obligations/attr/test_attr_for_triggers/value/test_valu_for_trigger"
],
"permissions": []
}
},
"action": {
"type": "rewrap",
"result": "success"
},
"actor": {
"id": "031fe452-ddbb-4d36-b82f-c6b3dd4d122a",
"attributes": []
},
"eventMetaData": {
"algorithm": "rsa:2048",
"keyID": "r1",
"policyBinding": "YjEwNWMwZGVhMjkzYjBhZjU4MWNkOTE1MmU4N2NkNjkzNzQ2ODM5NDI0MGRjYjhmNjRiZjlhNmY0OWEzZjJlNw==",
"tdfFormat": "tdf3"
},
"clientInfo": {
"userAgent": "connect-go/1.18.1 (go1.24.6)",
"platform": "kas",
"requestIP": "None"
},
"original": null,
"updated": null,
"requestID": "73f131ae-cc21-490c-868d-260e58b8664d",
"timestamp": "2025-10-31T11:58:40-05:00"
}
}
```
### Checklist
- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation
### Testing Instructions
(cherry picked from commit 4fe97fd)
opentdf-automation
bot
force-pushed
the
backport-2861-to-release/service/v0.11
branch
from
b03d861 to
874e693
Compare
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Contributor
Contributor
strantalis
approved these changes
Nov 3, 2025
jakedoublev
pushed a commit
that referenced
this pull request
Nov 7, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.3](service/v0.11.2...service/v0.11.3) (2025-11-07) ### Features * **kas:** Add nano policy binding to rewrap audit. [backport to release/service/v0.11] ([#2880](#2880)) ([d8558f3](d8558f3)) ### Bug Fixes * **authz:** if entity identifier results in multiple representations, treat with AND in resource decision results [backport to release/service/v0.11] ([#2887](#2887)) ([f772064](f772064)) * **kas:** populate rewrap audit log [backport to release/service/v0.11] ([#2867](#2867)) ([f460972](f460972)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2861 to
release/service/v0.11.