fix(core): DSPX-1944 Fix service negation for extra services #2905

elizabethhealy · 2025-11-13T21:37:19Z

Proposed Changes

Allow for service negation for extra services specified via WithExtraServices and WithExtraCoreServices
WithExtraCoreServices -- service run under core and all
WithExtraServices -- services run under all and their own mode specified by their namespace (maintaining previous behavior)

Checklist

I have added or updated unit tests
I have added or updated integration tests (if appropriate)
I have added or updated documentation

Testing Instructions

github-actions · 2025-11-13T21:42:37Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	182.21186ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	95.168807ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	360.890358ms
Throughput	277.09 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	41.014799957s
Average Latency	408.002119ms
Throughput	121.91 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	28.980499419s
Average Latency	288.860628ms
Throughput	172.53 requests/second

github-actions · 2025-11-13T21:54:56Z

X-Test Results

opentdf~~platform~~EIYYI2.dockerbuild
cukes-report
✅ js-v0.4.34
✅ java-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

github-actions · 2025-11-17T19:47:34Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	146.376523ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	78.064259ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	501.659074ms
Throughput	199.34 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	37.711304961s
Average Latency	375.575399ms
Throughput	132.59 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	26.574591146s
Average Latency	264.983017ms
Throughput	188.15 requests/second

github-actions · 2025-11-17T19:58:42Z

X-Test Results

opentdf~~platform~~J7Y8LN.dockerbuild
cukes-report
✅ js-v0.4.34
✅ java-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

github-actions · 2025-11-17T20:01:49Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	156.135585ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	99.001387ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	359.882643ms
Throughput	277.87 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	38.705871663s
Average Latency	385.713249ms
Throughput	129.18 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	27.186305801s
Average Latency	271.130835ms
Throughput	183.92 requests/second

github-actions · 2025-11-17T20:10:30Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	181.376136ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	104.102652ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	365.873238ms
Throughput	273.32 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.750859121s
Average Latency	396.074562ms
Throughput	125.78 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	27.752209296s
Average Latency	276.715459ms
Throughput	180.17 requests/second

github-actions · 2025-11-17T20:13:23Z

X-Test Results

opentdf~~platform~~SZFME6.dockerbuild
cukes-report
✅ java-v0.4.34
✅ js-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

github-actions · 2025-11-17T20:17:28Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	146.693363ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	85.515066ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	366.127511ms
Throughput	273.13 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.069656552s
Average Latency	389.232057ms
Throughput	127.98 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	27.168513698s
Average Latency	270.747699ms
Throughput	184.04 requests/second

github-actions · 2025-11-17T20:22:25Z

X-Test Results

opentdf~~platform~~68XDPL.dockerbuild
cukes-report
✅ js-v0.4.34
✅ java-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

strantalis · 2025-11-17T20:27:33Z

/gemini review

gemini-code-assist

Code Review

This pull request effectively adds support for service negation for extra services by refactoring the registration logic to use RegisterServicesFromConfiguration. The introduction of getServiceConfigurationsFromIServices is a good abstraction. The test coverage is excellent, with comprehensive new tests for negation and backward compatibility.

I've left a few comments for minor improvements, including fixing a misleading error message, improving efficiency by pre-allocating a slice, and simplifying test code by removing redundant checks. Overall, this is a solid contribution that improves the flexibility of service configuration.

service/pkg/server/services.go

service/pkg/server/services_test.go

service/pkg/server/start.go

github-actions · 2025-11-17T20:29:10Z

X-Test Results

opentdf~~platform~~VWW26M.dockerbuild
✅ java-v0.4.34
cukes-report
✅ js-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

github-actions · 2025-11-17T20:54:23Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	187.266327ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	109.612021ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	385.126199ms
Throughput	259.66 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	41.356632119s
Average Latency	412.19029ms
Throughput	120.90 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	28.575052404s
Average Latency	284.840985ms
Throughput	174.98 requests/second

github-actions · 2025-11-17T21:05:44Z

X-Test Results

opentdf~~platform~~EWDFY3.dockerbuild
cukes-report
✅ js-v0.4.34
✅ java-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

github-actions · 2025-11-18T04:39:59Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	183.260154ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	104.008734ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	360.954067ms
Throughput	277.04 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.72193815s
Average Latency	395.44624ms
Throughput	125.88 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	27.922857484s
Average Latency	278.412588ms
Throughput	179.06 requests/second

github-actions · 2025-11-18T04:53:09Z

X-Test Results

opentdf~~platform~~CWPU19.dockerbuild
cukes-report
✅ js-v0.4.34
✅ java-v0.4.34
✅ go-v0.4.34
bats-test-results
test-cases-mapping-report
✅ js-pull-2905
✅ java-pull-2905
✅ go-pull-2905

service/pkg/server/services_test.go

fix service negation for extra services

214d13e

github-actions bot added the size/s label Nov 13, 2025

add test cases

65e4f3c

linting

db00a11

elizabethhealy changed the title ~~fix(service): DSPX-1944 Fix service negation for extra services~~ fix(core): DSPX-1944 Fix service negation for extra services Nov 17, 2025

linting

b8f47bf

linting

71cb185

elizabethhealy marked this pull request as ready for review November 17, 2025 20:20

elizabethhealy requested a review from a team as a code owner November 17, 2025 20:20

gemini-code-assist bot reviewed Nov 17, 2025

View reviewed changes

strantalis previously approved these changes Nov 17, 2025

View reviewed changes

gemini suggestions

c89bf2d

elizabethhealy dismissed strantalis’s stale review via c89bf2d November 17, 2025 20:48

elizabethhealy requested a review from strantalis November 17, 2025 20:48

dmihalcik-virtru previously approved these changes Nov 17, 2025

View reviewed changes

linting

d8a20fd

elizabethhealy dismissed dmihalcik-virtru’s stale review via d8a20fd November 18, 2025 04:34

elizabethhealy requested a review from dmihalcik-virtru November 18, 2025 04:35

strantalis approved these changes Nov 18, 2025

View reviewed changes

jakedoublev reviewed Nov 18, 2025

View reviewed changes

service/pkg/server/services_test.go Show resolved Hide resolved

jakedoublev approved these changes Nov 18, 2025

View reviewed changes

elizabethhealy added this pull request to the merge queue Nov 18, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025

elizabethhealy added this pull request to the merge queue Nov 18, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025

elizabethhealy added this pull request to the merge queue Nov 18, 2025

Merged via the queue into main with commit b07a4fe Nov 18, 2025
39 checks passed

elizabethhealy deleted the dspx-1944-fix-mode-negation-extra-services branch November 18, 2025 20:05

opentdf-automation bot mentioned this pull request Nov 18, 2025

chore(main): release service 0.12.0 #2841

Open

fix(core): DSPX-1944 Fix service negation for extra services #2905

fix(core): DSPX-1944 Fix service negation for extra services #2905

Uh oh!

Conversation

elizabethhealy commented Nov 13, 2025

Proposed Changes

Checklist

Testing Instructions

Uh oh!

github-actions bot commented Nov 13, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Uh oh!

github-actions bot commented Nov 13, 2025

X-Test Results

Uh oh!

github-actions bot commented Nov 17, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Uh oh!

github-actions bot commented Nov 17, 2025

X-Test Results

Uh oh!

github-actions bot commented Nov 17, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Uh oh!

github-actions bot commented Nov 17, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Uh oh!

github-actions bot commented Nov 17, 2025

X-Test Results

Uh oh!

github-actions bot commented Nov 17, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

NANOTDF Benchmark Results:

Uh oh!

github-actions bot commented Nov 17, 2025

X-Test Results

Uh oh!

strantalis commented Nov 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 17, 2025

X-Test Results

Uh oh!

github-actions bot commented Nov 17, 2025

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics