Skip to content

Conversation

@imdominicreed
Copy link
Contributor

@imdominicreed imdominicreed commented Dec 1, 2025

Proposed Changes

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@imdominicreed imdominicreed requested review from a team as code owners December 1, 2025 20:35
@github-actions github-actions bot added comp:sdk A software development kit, including library, for client applications and inter-service communicati size/xs labels Dec 1, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @imdominicreed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a fix within the SDK's LoadTDF function to ensure the KAS session key is correctly and consistently applied during the TDF loading process. By adjusting the timing of when the session key is added to the reader options, the change guarantees that the key is always included in the initial configuration, which is vital for proper TDF decryption and handling.

Highlights

  • KAS Session Key Application: The logic responsible for applying the KAS session key (s.kasSessionKey) as a TDFReaderOption has been refactored and relocated within the LoadTDF function.
  • Timing of Option Application: The withSessionKey option is now applied earlier in the LoadTDF function, specifically before the newTDFReaderConfig is initialized, ensuring it's part of the initial configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Key moves, now it works, Session secure, data flows, Code finds its true path.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the LoadTDF function where the KAS session key from the SDK was not being applied to the TDF reader options. By moving the logic to prepend the session key option to before the newTDFReaderConfig call, the change ensures that the session key is properly configured for the TDF reader. The fix is straightforward and improves the correctness of the SDK.

@imdominicreed imdominicreed added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@imdominicreed imdominicreed added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@jakedoublev jakedoublev added this pull request to the merge queue Dec 3, 2025
Merged via the queue into opentdf:main with commit 736f250 Dec 3, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:sdk A software development kit, including library, for client applications and inter-service communicati size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants