-
Notifications
You must be signed in to change notification settings - Fork 24
feat: Update Go toolchain version to 1.24.11 across all modules #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pflynn-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a crucial maintenance update by standardizing the Go toolchain and Go version across various modules within the repository. The transition to Go 1.24.11 ensures that all components benefit from the latest stability fixes and performance enhancements available in the Go 1.24.x release line, contributing to a more robust and consistent development environment. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. New Go version flies, Patches bring stability, Code now runs so smooth. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates the Go toolchain version to go1.24.11 across all specified modules and the go.work file. This is a good step towards ensuring consistency and leveraging the latest patches and improvements in the Go 1.24.x series. However, I've noticed an inconsistency in several go.mod files where only the toolchain directive was updated, while the go directive remains at an older version (e.g., go 1.24.0 or go 1.23.0). The pull request description states that both the "Go version and toolchain" are being updated. For clarity and to fully utilize the updated Go version, it would be beneficial to align the go directive with the toolchain directive in these modules.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
🤖 I have created a release *beep* *boop* --- ## [0.14.0](protocol/go/v0.13.0...protocol/go/v0.14.0) (2025-12-19) ### Features * Update Go toolchain version to 1.24.11 across all modules ([#2943](#2943)) ([a960eca](a960eca)) ### Bug Fixes * **deps:** bump toolchain to go1.24.9 for CVEs found by govulncheck ([#2849](#2849)) ([23f76c0](23f76c0)) * **kas:** document rewrap proto fields used in bulk flow ([#2826](#2826)) ([32a7e91](32a7e91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.0](lib/fixtures/v0.3.0...lib/fixtures/v0.4.0) (2025-12-19) ### Features * Update Go toolchain version to 1.24.11 across all modules ([#2943](#2943)) ([a960eca](a960eca)) ### Bug Fixes * **deps:** bump toolchain to go1.24.9 for CVEs found by govulncheck ([#2849](#2849)) ([23f76c0](23f76c0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.8.0](lib/ocrypto/v0.7.0...lib/ocrypto/v0.8.0) (2025-12-19) ### Features * Update Go toolchain version to 1.24.11 across all modules ([#2943](#2943)) ([a960eca](a960eca)) ### Bug Fixes * **deps:** bump toolchain to go1.24.9 for CVEs found by govulncheck ([#2849](#2849)) ([23f76c0](23f76c0)) * **sdk:** more efficient encryption in experiment TDF Writer ([#2904](#2904)) ([3ec0518](3ec0518)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.11.0](sdk/v0.10.0...sdk/v0.11.0) (2026-01-06) ### Features * crypto.Signer in assertion signing ([#2956](#2956)) ([ab36c3a](ab36c3a)) * **sdk:** adds configurable max manifest sizes ([#2906](#2906)) ([e418a4b](e418a4b)) * **sdk:** Expose policy binding hash from Nano. ([#2857](#2857)) ([5221cf4](5221cf4)) * **sdk:** JWK-based signature verification for assertions ([#2985](#2985)) ([ef4b5b5](ef4b5b5)) * Update Go toolchain version to 1.24.11 across all modules ([#2943](#2943)) ([a960eca](a960eca)) ### Bug Fixes * **deps:** bump github.com/opentdf/platform/lib/fixtures from 0.3.0 to 0.4.0 in /sdk ([#2962](#2962)) ([fbb5985](fbb5985)) * **deps:** bump github.com/opentdf/platform/lib/ocrypto from 0.7.0 to 0.8.0 in /sdk ([#2975](#2975)) ([6fc9b46](6fc9b46)) * **deps:** bump github.com/opentdf/platform/protocol/go from 0.13.0 to 0.14.0 in /sdk ([#2963](#2963)) ([3606421](3606421)) * **deps:** bump the external group across 1 directory with 5 updates ([#2950](#2950)) ([6dc3bca](6dc3bca)) * **deps:** bump toolchain to go1.24.9 for CVEs found by govulncheck ([#2849](#2849)) ([23f76c0](23f76c0)) * **sdk:** more efficient encryption in experiment TDF Writer ([#2904](#2904)) ([3ec0518](3ec0518)) * **sdk:** uses kas sessions key ([#2940](#2940)) ([736f250](736f250)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Proposed Changes
This pull request updates the Go toolchain and Go version across multiple modules in the repository to use Go 1.24.11 instead of Go 1.24.9. This ensures consistency and access to the latest patches and improvements in the Go 1.24.x series.
Go version and toolchain updates:
goversion and/ortoolchaindirective togo1.24.11in the following files and modules:examples/go.mod(github.com/opentdf/platform/examples)lib/fixtures/go.mod(github.com/opentdf/platform/lib/fixtures)lib/ocrypto/go.mod(github.com/opentdf/platform/lib/ocrypto)protocol/go/go.mod(github.com/opentdf/platform/protocol/go)sdk/go.mod(github.com/opentdf/platform/sdk)service/go.mod(github.com/opentdf/platform/service)tests-bdd/go.modgo.workChecklist
Testing Instructions