Skip to content

Conversation

@strantalis
Copy link
Member

Proposed Changes

The Config struct had two places where tracing.Config was embedded:

  • config.Config.Trace (root level) - UNUSED
  • server.Config.Trace (under server) - ACTUALLY USED

Only cfg.Server.Trace was ever passed to tracing.InitTracer in start.go, making the root-level Trace field dead code.

Changes:

  • Remove unused Trace field from config.Config struct
  • Remove unused tracing package import from config.go
  • Fix docs to use correct server.trace.* paths instead of trace.*
  • Move Tracing Configuration section under Server Configuration in docs
  • Add YAML example showing correct configuration structure

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

The Config struct had two places where tracing.Config was embedded:
- config.Config.Trace (root level) - UNUSED
- server.Config.Trace (under server) - ACTUALLY USED

Only cfg.Server.Trace was ever passed to tracing.InitTracer in start.go,
making the root-level Trace field dead code.

Changes:
- Remove unused Trace field from config.Config struct
- Remove unused tracing package import from config.go
- Fix docs to use correct server.trace.* paths instead of trace.*
- Move Tracing Configuration section under Server Configuration in docs
- Add YAML example showing correct configuration structure
@strantalis strantalis requested a review from a team as a code owner December 4, 2025 16:11
@github-actions github-actions bot added the docs Documentation label Dec 4, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the core configuration by removing a redundant and unused root-level tracing configuration field and its associated import. It also updates the documentation to accurately reflect the active tracing configuration path, ensuring that users configure tracing correctly under the server section with a clear YAML example.

Highlights

  • Code Cleanup: Removed an unused Trace field from the root config.Config struct, which was identified as dead code since only server.Config.Trace was actively used for tracing initialization.
  • Dependency Management: Eliminated the unnecessary import of the tracing package in config.go after removing the unused root-level trace configuration.
  • Documentation Update: Updated the Configuring.md documentation to reflect the correct server.trace.* configuration paths and moved the entire "Tracing Configuration" section under "Server Configuration" for better organization and accuracy.
  • Configuration Example: Added a YAML example to the documentation to clearly illustrate the correct structure for configuring tracing under the server section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Old code, unused, Removed, a cleaner path, Docs now align.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the size/s label Dec 4, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the unused root-level trace configuration, which cleans up the codebase by removing dead code. The associated documentation changes are also accurate. I have one suggestion to improve the consistency and completeness of the new documentation for tracing configuration.

@strantalis strantalis enabled auto-merge December 4, 2025 17:12
@strantalis strantalis added this pull request to the merge queue Dec 4, 2025
Merged via the queue into opentdf:main with commit d323e85 Dec 4, 2025
42 checks passed
@strantalis strantalis deleted the fix/duplicate-trace-config branch December 4, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants