-
Notifications
You must be signed in to change notification settings - Fork 24
fix(core): remove duplicate root-level trace configuration #2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Config struct had two places where tracing.Config was embedded: - config.Config.Trace (root level) - UNUSED - server.Config.Trace (under server) - ACTUALLY USED Only cfg.Server.Trace was ever passed to tracing.InitTracer in start.go, making the root-level Trace field dead code. Changes: - Remove unused Trace field from config.Config struct - Remove unused tracing package import from config.go - Fix docs to use correct server.trace.* paths instead of trace.* - Move Tracing Configuration section under Server Configuration in docs - Add YAML example showing correct configuration structure
Summary of ChangesHello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the core configuration by removing a redundant and unused root-level tracing configuration field and its associated import. It also updates the documentation to accurately reflect the active tracing configuration path, ensuring that users configure tracing correctly under the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Old code, unused, Removed, a cleaner path, Docs now align. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the unused root-level trace configuration, which cleans up the codebase by removing dead code. The associated documentation changes are also accurate. I have one suggestion to improve the consistency and completeness of the new documentation for tracing configuration.
Proposed Changes
The Config struct had two places where tracing.Config was embedded:
Only cfg.Server.Trace was ever passed to tracing.InitTracer in start.go, making the root-level Trace field dead code.
Changes:
Checklist
Testing Instructions