Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pods limits according to best practice #1057

Open
vladimirhasko opened this issue Jun 27, 2024 · 1 comment
Open

Fix the pods limits according to best practice #1057

vladimirhasko opened this issue Jun 27, 2024 · 1 comment
Assignees

Comments

@vladimirhasko
Copy link
Member

The applied limits changes at #936
are causing that limits and requests are on the same value.
This endangers pod to out of memory situation when it needs some RAM (requests) but it's not allowed to use more (equal to limits)
Therefore raise limits to be higher than requests
Additionally these changes should be applied in overalay approach instead of base changes.

@gtema
Copy link
Member

gtema commented Jun 27, 2024

Well, actually only limits should have been raised and requests not touched. requests influences where K8 will schedule the pod (ensure that at least that amount is available) - and with previous values Zuul was working perfectly fine for a very long time. Fact that under some conditions it may require more is controlled by limits which define the upper limit of what pod can consume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants