Merge pull request #2142 from opentensor/chore/refactor-subnet-emissions

Refactor subnet emissions

Author: sam0x17

pallets/subtensor/src/coinbase/mod.rs

@@ -4,3 +4,4 @@ pub mod block_step;
 pub mod reveal_commits;
 pub mod root;
 pub mod run_coinbase;
+pub mod subnet_emissions;

pallets/subtensor/src/coinbase/run_coinbase.rs

@@ -30,24 +30,10 @@ impl<T: Config> Pallet<T> {
             .filter(|netuid| *netuid != NetUid::ROOT)
             .collect();
         log::debug!("All subnet netuids: {subnets:?}");
-        // Filter out subnets with no first emission block number.
-        let subnets_to_emit_to: Vec<NetUid> = subnets
-            .clone()
-            .into_iter()
-            .filter(|netuid| FirstEmissionBlockNumber::<T>::get(*netuid).is_some())
-            .collect();
-        log::debug!("Subnets to emit to: {subnets_to_emit_to:?}");
 
-        // --- 2. Get sum of tao reserves ( in a later version we will switch to prices. )
-        let mut acc_total_moving_prices = U96F32::saturating_from_num(0.0);
-        // Only get price EMA for subnets that we emit to.
-        for netuid_i in subnets_to_emit_to.iter() {
-            // Get and update the moving price of each subnet adding the total together.
-            acc_total_moving_prices =
-                acc_total_moving_prices.saturating_add(Self::get_moving_alpha_price(*netuid_i));
-        }
-        let total_moving_prices = acc_total_moving_prices;
-        log::debug!("total_moving_prices: {total_moving_prices:?}");
+        // 2. Get subnets to emit to and emissions
+        let subnet_emissions = Self::get_subnet_block_emissions(&subnets, block_emission);
+        let subnets_to_emit_to: Vec<NetUid> = subnet_emissions.keys().copied().collect();
 
         // --- 3. Get subnet terms (tao_in, alpha_in, and alpha_out)
         // Computation is described in detail in the dtao whitepaper.
@@ -60,14 +46,11 @@ impl<T: Config> Pallet<T> {
             // Get subnet price.
             let price_i = T::SwapInterface::current_alpha_price((*netuid_i).into());
             log::debug!("price_i: {price_i:?}");
-            // Get subnet TAO.
-            let moving_price_i: U96F32 = Self::get_moving_alpha_price(*netuid_i);
-            log::debug!("moving_price_i: {moving_price_i:?}");
             // Emission is price over total.
-            let default_tao_in_i: U96F32 = block_emission
-                .saturating_mul(moving_price_i)
-                .checked_div(total_moving_prices)
-                .unwrap_or(asfloat!(0.0));
+            let default_tao_in_i: U96F32 = subnet_emissions
+                .get(netuid_i)
+                .copied()
+                .unwrap_or(asfloat!(0));
             log::debug!("default_tao_in_i: {default_tao_in_i:?}");
             // Get alpha_emission total
             let alpha_emission_i: U96F32 = asfloat!(

pallets/subtensor/src/coinbase/subnet_emissions.rs

@@ -0,0 +1,45 @@
+use super::*;
+use crate::alloc::borrow::ToOwned;
+use alloc::collections::BTreeMap;
+use substrate_fixed::types::U96F32;
+
+impl<T: Config> Pallet<T> {
+    pub fn get_subnet_block_emissions(
+        subnets: &[NetUid],
+        block_emission: U96F32,
+    ) -> BTreeMap<NetUid, U96F32> {
+        // Filter out subnets with no first emission block number.
+        let subnets_to_emit_to: Vec<NetUid> = subnets
+            .to_owned()
+            .clone()
+            .into_iter()
+            .filter(|netuid| FirstEmissionBlockNumber::<T>::get(*netuid).is_some())
+            .collect();
+        log::debug!("Subnets to emit to: {subnets_to_emit_to:?}");
+
+        // Get sum of alpha moving prices
+        let total_moving_prices = subnets_to_emit_to
+            .iter()
+            .map(|netuid| Self::get_moving_alpha_price(*netuid))
+            .fold(U96F32::saturating_from_num(0.0), |acc, ema| {
+                acc.saturating_add(ema)
+            });
+        log::debug!("total_moving_prices: {total_moving_prices:?}");
+
+        // Get subnet TAO emissions.
+        subnets_to_emit_to
+            .into_iter()
+            .map(|netuid| {
+                let moving_price = Self::get_moving_alpha_price(netuid);
+                log::debug!("moving_price_i: {moving_price:?}");
+
+                let share = block_emission
+                    .saturating_mul(moving_price)
+                    .checked_div(total_moving_prices)
+                    .unwrap_or(U96F32::from_num(0));
+
+                (netuid, share)
+            })
+            .collect::<BTreeMap<NetUid, U96F32>>()
+    }
+}