Fix swap_coldkey tests

Author: ales-otf

pallets/admin-utils/src/tests/mock.rs

@@ -1,5 +1,7 @@
 #![allow(clippy::arithmetic_side_effects, clippy::unwrap_used)]
 
+use core::num::NonZeroU64;
+
 use frame_support::{
     PalletId, assert_ok, derive_impl, parameter_types,
     traits::{Everything, Hooks, PrivilegeCmp},
@@ -267,6 +269,7 @@ parameter_types! {
     pub const SwapMaxFeeRate: u16 = 10000; // 15.26%
     pub const SwapMaxPositions: u32 = 100;
     pub const SwapMinimumLiquidity: u64 = 1_000;
+    pub const SwapMinimumReserve: NonZeroU64 = NonZeroU64::new(1_000_000).unwrap();
 }
 
 impl pallet_subtensor_swap::Config for Test {
@@ -277,6 +280,7 @@ impl pallet_subtensor_swap::Config for Test {
     type MaxFeeRate = SwapMaxFeeRate;
     type MaxPositions = SwapMaxPositions;
     type MinimumLiquidity = SwapMinimumLiquidity;
+    type MinimumReserve = SwapMinimumReserve;
     type WeightInfo = ();
 }
 

pallets/subtensor/src/tests/mock.rs

@@ -1,5 +1,7 @@
 #![allow(clippy::arithmetic_side_effects, clippy::unwrap_used)]
-use crate::utils::rate_limiting::TransactionType;
+
+use core::num::NonZeroU64;
+
 use frame_support::PalletId;
 use frame_support::derive_impl;
 use frame_support::dispatch::DispatchResultWithPostInfo;
@@ -20,8 +22,9 @@ use sp_runtime::{
 };
 use sp_std::cmp::Ordering;
 use substrate_fixed::types::U64F64;
-use subtensor_swap_interface::{LiquidityDataProvider, SwapHandler};
+use subtensor_swap_interface::{LiquidityDataProvider, OrderType, SwapHandler};
 
+use crate::utils::rate_limiting::TransactionType;
 use crate::*;
 
 type Block = frame_system::mocking::MockBlock<Test>;
@@ -423,6 +426,7 @@ parameter_types! {
     pub const SwapMaxFeeRate: u16 = 10000; // 15.26%
     pub const SwapMaxPositions: u32 = 100;
     pub const SwapMinimumLiquidity: u64 = 1_000;
+    pub const SwapMinimumReserve: NonZeroU64 = NonZeroU64::new(1).unwrap();
 }
 
 impl pallet_subtensor_swap::Config for Test {
@@ -433,6 +437,7 @@ impl pallet_subtensor_swap::Config for Test {
     type MaxFeeRate = SwapMaxFeeRate;
     type MaxPositions = SwapMaxPositions;
     type MinimumLiquidity = SwapMinimumLiquidity;
+    type MinimumReserve = SwapMinimumReserve;
     type WeightInfo = ();
 }
 
@@ -852,3 +857,27 @@ pub fn increase_stake_on_hotkey_account(hotkey: &U256, increment: u64, netuid: u
         netuid,
     );
 }
+
+pub(crate) fn setup_reserves(netuid: u16, tao: u64, alpha: u64) {
+    SubnetTAO::<Test>::set(netuid, tao);
+    SubnetAlphaIn::<Test>::set(netuid, alpha);
+}
+
+pub(crate) fn swap_tao_to_alpha(netuid: u16, tao: u64) -> u64 {
+    let result = <Test as pallet::Config>::SwapInterface::swap(
+        netuid,
+        OrderType::Buy,
+        tao,
+        <Test as pallet::Config>::SwapInterface::max_price(),
+        true,
+    );
+
+    assert_ok!(&result);
+
+    let result = result.unwrap().amount_paid_out;
+
+    // we don't want to have silent 0 comparissons in tests
+    assert!(result > 0);
+
+    result
+}