Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bosstiary / bestiary don't give a progress if you don't be the mostDamageKiller #1807

Closed
2 of 5 tasks
Schiffers opened this issue Nov 11, 2023 · 4 comments · Fixed by #1813
Closed
2 of 5 tasks

Bosstiary / bestiary don't give a progress if you don't be the mostDamageKiller #1807

Schiffers opened this issue Nov 11, 2023 · 4 comments · Fixed by #1813
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Schiffers
Copy link
Contributor

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

after #1792 the bosstiary / bestiary monsters dont give a count if you dont are the mostDamageKiller

tested with bosses (alot of times) and monsters (more alot of times)

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Schiffers Schiffers added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 11, 2023
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Nov 11, 2023
@dudantas
Copy link
Member

How do you think it's supposed to work?

@Schiffers
Copy link
Contributor Author

the counter of bosstiary should give the counter to any player that give damage
the counter if besttiary should give the counter to any player that give damage aswell...
since we have rare creatures in the game, I saw alot of videos of players that find a rare monster and call everyone to get the bestiary...

@Leshyah
Copy link
Contributor

Leshyah commented Nov 11, 2023 •
edited
Loading

Taken from (source): https://tibia.fandom.com/wiki/Cyclopedia#Bestiary
bestiary

I have not tested this myself but if what schiffers says is happening then it should be changed in the src to give all players who attack, and do at least 1 hitpoint of damage, credit towards their bestiary/bosstiary.

Edit: Tested and confirmed issue is valid with latest repo.

@Leshyah
Copy link
Contributor

Leshyah commented Nov 13, 2023

This can now be closed. Fixed with #1813

@dudantas dudantas mentioned this issue Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bestiary kills and boss boost opentibiabr/canary
3 participants
@dudantas @Schiffers @Leshyah