Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: bug on time in all rings (onDeEquip) #244

Closed
1 task done
Sh3Ns opened this issue Feb 26, 2022 · 7 comments · Fixed by #238
Closed
1 task done

[Bug]: bug on time in all rings (onDeEquip) #244

Sh3Ns opened this issue Feb 26, 2022 · 7 comments · Fixed by #238
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Sh3Ns
Copy link

Sh3Ns commented Feb 26, 2022

What happened?

usando o ring , ele nao está contando o tempo certo.

How to Reproduce?

equipando os rings.

lista rings

time ring
energy ring
club ring
power ring
ring of healing
dwarven ring
stealth ring
sword ring
axe ring

Relevant log output

No response

Attach any relevant file

image

Version

12.x (Default)

What OS are you seeing the problem on?

Windows 10

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Sh3Ns Sh3Ns added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 26, 2022
@ghost
Copy link

ghost commented Feb 27, 2022

bug appeared after merging #228

@majestyotbr
Copy link
Contributor

bug appeared after merging opentibiabr/canary#228

Thanks, we already know that. I asked for more tests and waited few hours before the merge and nobody tested to confirm the bug while in pull request.
We'd appreciate if people that are using the base could help test pull requests too.
If you find bugs while testing a pull request, be clearer when explaining the problem.

@majestyotbr
Copy link
Contributor

Remember to access our discord:
https://discordapp.com/invite/3NxYnyV
There we can talk about issues and pull requests, to avoid problems like that. Thanks.

@majestyotbr majestyotbr transferred this issue from opentibiabr/otservbr-global Feb 28, 2022
@majestyotbr majestyotbr linked a pull request Mar 1, 2022 that will close this issue
1 task
@kamahall
Copy link

kamahall commented Mar 8, 2022

is there any fix for this?

@ghost
Copy link

ghost commented Mar 8, 2022

#238

@kamahall
Copy link

kamahall commented Mar 8, 2022

It still has the same error, when placing the ring it is still infinite and says 0 seconds to finish

@ghost
Copy link

ghost commented Mar 8, 2022

it's work in progress if you didn't notice, this PR is going to fix 2 issues with rings, one is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants