Request for unified 'react-native link` package setup for both iOS and Android

[sunweiyang]

This opentok-react-native package has rather manual setup steps for iOS, and only uses react-native link for Android.

The common practice now is to use react-native link for efficient package setup, with optional manual steps to replace react-native link when problems arise.

[msach22]

@sunweiyang Agreed! It's on our ToDo list to get it working for iOS as well!

[ghost]

Hello @msach22
Is it possible to install on iOS without using use_frameworks!?

Why

1. Using use_frameworks! is slow and brings a lot of problems with some other packages like react-native-pdf, react-native-vector-icons...
2. In cocoapods==1.5.0 already available Swift Static Libraries http://blog.cocoapods.org/CocoaPods-1.5.0/

Thanks!

[msach22]

@ASerga Thanks for reporting this! I'll investigate further and see what we can do!

[msach22]

@sunweiyang @ASerga Just wanted to update you folks that this is a WIP and should go out with 0.7.0

[emin93]

Usually I'm not fanboying things, but this time: A BIG thank you! I was so close to giving up on integrating audio / video chat in my app before I stumbled upon OpenTok. Everything just worked flawlessly! Great documentation and clean integration.

As soon as the iOS setup works with react-native link as well, it will be the perfect module! 😃

P.S. GitHub needs an appreciation page for repositories 😄

[msach22]

Thanks for the kind words @emin93!

I've opened a PR for the react-native link installation, but it still requires you to create an empty swift file in your iOS project to avoid a compiling error. If anyone else has a solution, please feel free to share!

[sunweiyang]

@msach22 Thanks again! And perhaps this might give some insight:
https://github.com/rhdeck/react-native-swift
Also there's this stale issue about RN Swift built-in support: facebook/react-native#13030

[msach22]

@sunweiyang Looks like this package is also creating an empty swift file: https://github.com/rhdeck/react-native-swift/blob/master/bin/postlink.js#L35

When you create a Swift file, XCode creates a Objective-C Generated Interface Header Name which is needed to import Swift into Objective-C. Looks like in this case also needed to be able to compile the Swift libraries.

[msach22]

Also mentions the need to add an empty file:
https://github.com/rhdeck/react-native-swift/blob/master/README.md#how-it-works

[msach22]

@sunweiyang In any case, I think I'm going to proceed with the empty swift file solution for now and improve as we can. I know it's not a optimal solution, but it is still a step forward because it allows you to use the library without having to use use_frameworks.

[mfranceschit]

Thanks for this improvement @msach22 ! I've taken the desition to migrate to this library from react-native-opentok and this changes will be very useful to me because I'm having some problems with others libraries with the use_framework flag.

[msach22]

Released with 0.7.0