Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue getting beans to autoconfigure #30

Open
tvfoodmaps opened this issue Dec 13, 2018 · 4 comments
Open

Issue getting beans to autoconfigure #30

tvfoodmaps opened this issue Dec 13, 2018 · 4 comments

Comments

@tvfoodmaps
Copy link

tvfoodmaps commented Dec 13, 2018

I am trying to add metrics to my spring boot app (already working with Jaegar for traces and working with micrometer for standard spring actuators).

When I add

compile('io.opentracing.contrib:opentracing-metrics-prometheus-spring-autoconfigure:0.3.0')
to my gradle file it replaces the original spring data at /actuators/prometheus.

If I remove that instead add a bean:

@Bean public MetricsFactory metricsFactory() { return new MicrometerMetricsFactory(); }

I see some jaeger metrics but none of the per span information I'm interested in. What I would like is to have /actuators/prometheus show both the standard spring metrics AND the jaegar, per-span, info. Any assistance is appreciated.

@objectiser
Copy link
Contributor

@tvfoodmaps Thanks for reporting this. Unfortunately will not be able to investigate until the new year.

Would you be interested in providing a PR?

@tvfoodmaps
Copy link
Author

tvfoodmaps commented Dec 14, 2018

Would love to begin to contribute. I don't think there is PR for code, I ended up getting this working with a lot of trial and error so if anything I think there is perhaps some documentation updates needed.

Also to keep the trail complete, I also had this issue as I was confused which of the projects was causing an issue. opentracing-contrib/java-spring-jaeger#31 (comment)

Perhaps improved documentation around how these various projects interact would be helpful.

@objectiser
Copy link
Contributor

@tvfoodmaps Would be great if you could provide a docs PR improving areas where you had problems.

@himanshumps
Copy link

@tvfoodmaps How did you get it to work. Please share sample code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants