Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a TracerConverter to enable metrics to automatically be applied to resolver Tracer #9

Open
objectiser opened this issue Jun 16, 2017 · 0 comments

Comments

@objectiser
Copy link
Contributor

The TracerConverter implementation should automatically decorate a resolver Tracer with the metrics capability.

One issue to consider is how best to obtain the MetricsReporter implementation and how it will be configured.

For example, the PrometheusMetricsReporter does not expose an endpoint for collection (scraping) of the metric data - this is left to the application, which may be using Prometheus to collect other metrics, and/or want to decide how best to expose (or push) the metrics.

When the TracerResolver/Converter approach is being used, it likely that the application may not be aware of the tracing or metrics collection - therefore an additional mechanism will be required to enable the appropriate metrics endpoint to be initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant