Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration with Opentracing #2

Closed
3 tasks
hkshaw1990 opened this issue Feb 17, 2017 · 2 comments
Closed
3 tasks

Integration with Opentracing #2

hkshaw1990 opened this issue Feb 17, 2017 · 2 comments

Comments

@hkshaw1990
Copy link
Collaborator

hkshaw1990 commented Feb 17, 2017 •
edited
Loading

This issue is a placeholder to track the immediate plan with perfevents go API development with respect to Opentracing and zipkin-go-opentracing (as a backend).

TODOs :

  • Implement basic perf events and an API to be used by the Opentracing tracers.
  • Modify opentracing-go to accept perfevents (and passing the event list on to the backend tracer) while starting a span.
  • Add usage of perf events to zipkin-go-opentracing.
@hkshaw1990 hkshaw1990 mentioned this issue Feb 17, 2017
Merged
@hkshaw1990 hkshaw1990 changed the title Track the go perfevents PRs Integration with Opentracing Feb 17, 2017
@hkshaw1990
Copy link
Collaborator Author

PR to implement basic perf events and an API : #1
PR to modify opentracing-go : opentracing/opentracing-go#135
PR to add usage of perfevents with zipkin-go-opentracing : openzipkin-contrib/zipkin-go-opentracing#50

@hkshaw1990
Copy link
Collaborator Author

Owing to the new observer API, this issue and its TODOs should be considered obsolete. Tracking the integration with opentracing through observer on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkshaw1990