Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to subset fontawesome v6 - extended ligature lookup table not supported #505

Open
danielgindi opened this issue Feb 20, 2022 · 2 comments

Comments

@danielgindi
Copy link

I'm trying to subset FA's v6 files, by creating a new font, copying over the glyphs, reading the ligature lookup tables and mapping to new lookup tables in the new font.

Expected Behavior

Copy over the glyphs and their ligatures easily, generate a valid ttf.

Current Behavior

In any way I tried, an invalid font is generated.

Possible Solution

Steps to Reproduce (for bugs)

First, the builtin function getLigatures() only looks for lookupType=4, and not 7 which is "extended".
So I tried using getLookupTables, and mapping the ligature's indexes to the new indexes. I get a good looking lookup table after using addLigature on the new font.
Writing to a file - I get an invalid font. Probably because the glyphs are in a very high unicode area.
So I tried to mutate the generated lookup table to a lookupType of 7, and wrap the subtable in "extended" like the parser does.
Turns out - there is no "maker" for type 7, only parser. I tried writing a small maker for it based on the parser's config, but I still get an invalid ttf file.

Your Environment

  • Version used: 1.3.4
  • Font used: Font Awesome Pro v6
  • Operating System and version (desktop or mobile): Windows 10
@yne
Copy link
Contributor

yne commented Apr 21, 2022

seems related to: #486

@Connum
Copy link
Contributor

Connum commented Feb 11, 2023

seems related to: #486

That PR only adds parsing support, writing support is a different story and I just added #561 so we can keep track of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants