Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[invokers] stepUp and stepDown actions for number inputs #968

Closed
lukewarlow opened this issue Dec 3, 2023 · 1 comment · Fixed by #1029
Closed

[invokers] stepUp and stepDown actions for number inputs #968

lukewarlow opened this issue Dec 3, 2023 · 1 comment · Fixed by #1029
Labels
discussion Thoughts and opinions wanted invokers

Comments

@lukewarlow
Copy link
Collaborator

lukewarlow commented Dec 3, 2023

See #967 for a PR by @spookylukey

See:

The idea is that with this in place, we could easily create more visually appealing (and accessible) versions of <input type=number> without any javascript.

For example, the number widgets in this shopping basket from https://abilitynet.org.uk/training/how-use-screen-reader-accessibility-testing?utm_source=Intro-Screen-Readers&utm_medium=Factsheet-Highlights&utm_campaign=2023-Training-Promo

Screenshot 2023-12-03 at 14-15-42 How to use a screen reader for accessibility testing AbilityNet

It also requires some CSS to hide the native spinners - https://stackoverflow.com/questions/3790935/can-i-hide-the-html5-number-input-s-spin-box

Opening the issue to have a place to discuss and agenda+ if necessary.

@lukewarlow
Copy link
Collaborator Author

I'm not against the idea I think it fits into the spirit of invokers being "declarative method invocation".

I do think it'd need some thoughts on how exactly it's mapped to aria.

I also wonder if it's potentially the wrong solution. Should we just have a standardised anatomy for <input type="number"> that allows for the visually appealing design above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Thoughts and opinions wanted invokers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant