Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make not create scopedRegistry when scopes are empty #135

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Fix make not create scopedRegistry when scopes are empty #135

merged 2 commits into from
Jan 20, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Jan 20, 2024 •
edited
Loading

Changes

Not create scopedRegistry when scopes are empty.
Possible when specified @git, @htts, and @file with add subcommand.

fixed #134

@nowsprinting nowsprinting marked this pull request as ready for review January 20, 2024 02:36
favoyang
favoyang requested changes Jan 20, 2024
View reviewed changes
test/test-cmd-add.ts Show resolved Hide resolved
@favoyang
Copy link
Member

@all-contributors please add @nowsprinting for code and bug.

@allcontributors allcontributors bot mentioned this pull request Jan 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@favoyang

I've put up a pull request to add @nowsprinting! 🎉

@nowsprinting nowsprinting requested a review from favoyang January 20, 2024 06:32
favoyang
favoyang approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@favoyang favoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@favoyang favoyang merged commit f1a2000 into openupm:master Jan 20, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 20, 2024
@semantic-release-bot
chore(release): 1.19.7 [skip ci]
ff8364c 
## [1.19.7](1.19.6...1.19.7) (2024-01-20)

### Bug Fixes

* make not create scopedRegistry when scopes are empty ([#135](#135)) ([f1a2000](f1a2000)), closes [#134](#134)
@nowsprinting nowsprinting deleted the fix/not-create-scopedregistry branch January 20, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favoyang favoyang favoyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not create scopedRegistry when scopes are empty
2 participants
@nowsprinting @favoyang