-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Test option to package add #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. See the comments below.
Thanks for looking at my PR. I changed the things that you requested and don't know if there is anything it can be done about the |
Thanks for the quick fix! My comment is in #9 (comment) |
I copied the implementation from the deep function. Using object destructuring should bring a similar approach. Could you give it a second look please? I don't want to mess with the parameter's object and break the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
# [1.8.0](1.7.1...1.8.0) (2020-06-18) ### Features * add test option to the add command ([#9](#9)) ([9f976bd](9f976bd))
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added the option
-t
and--testables
to add the package name to thetestables
array.