Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No matches for a pair you'd expect (?) to find matches for #6

Open
thisisaaronland opened this issue Apr 17, 2018 · 3 comments
Open

Comments

@thisisaaronland
Copy link

Passing this along, FYI. These two venues were in the same set of candidates to dedupe but lieu didn't seem to pick up on them.

Isamu Noguchi Museum And Garden
32 37 Vernon Blvd Long Island City, Ny 11106
40.76713, -73.93773
Isamu Noguchi Foundation And Garden Museum
3237 Vernon Blvd Long Is City, Ny 11106-4926
40.76713, -73.93773
@albarrentine
Copy link
Contributor

House number doesn't match because of the space. We don't currently touch house numbers except for basic normalization and removing phrases like "#", "House No.", etc.

There are too many variants and edge cases around the world to use a one-size-fits-all approach for spaces/hyphens without losing information. If you know in advance the data set comes from one country or place, removing spaces and hyphens in preprocessing is an option.

@thisisaaronland
Copy link
Author

That's good to know. I can update the "prepare" tool accordingly. Are there any other similar rules / gotchas to be aware of or account for?

@albarrentine
Copy link
Contributor

albarrentine commented Apr 17, 2018

In data sets without lat/lons, postcodes are often useful, so with voter files for instance I've been normalizing to the ZIP5 in the US. Similarly in GB/CA might want to strip spaces as there can be a variety of different formats.

Some of that we may be able to implement on the libpostal side at some point if the postcode format is unique to a country (GB/CA are definitely unique and I don't think anywhere else in the world has DDDDD-DDDD, so might be fine to assume it's the US and match on the first 5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants