Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Refactor - make_folder3d_dataset is too complex (16 > 15)RuffC901 #1826

Closed
samet-akcay opened this issue Mar 7, 2024 · 1 comment · Fixed by #1926 or #2185
Closed

🔨 Refactor - make_folder3d_dataset is too complex (16 > 15)RuffC901 #1826

samet-akcay opened this issue Mar 7, 2024 · 1 comment · Fixed by #1926 or #2185
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Refactor Refactoring is needed
Milestone
v1.2.0

Comments

@samet-akcay
Copy link
Contributor

Description

ruff throws the following error for the make_folder3d_dataset function:

`make_folder3d_dataset` is too complex (16 > 15)RuffC901

It would be good to simplify this function to be within the complexity limit.
@samet-akcay samet-akcay added Refactor Refactoring is needed Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. labels Mar 7, 2024
@samet-akcay samet-akcay added this to the v1.1.0 milestone Mar 7, 2024
@sahusiddharth sahusiddharth mentioned this issue Mar 8, 2024
Closed
9 tasks
@sahusiddharth
Copy link
Contributor

sahusiddharth commented Mar 8, 2024 •
edited
Loading

Hey @samet-akcay, just a heads up: I made a separate PR for this issue, but it was already addressed in PR #1825.

@sahusiddharth sahusiddharth mentioned this issue Mar 27, 2024
Merged
@samet-akcay samet-akcay modified the milestones: v1.1.0, v1.2.0 May 24, 2024
@samet-akcay samet-akcay mentioned this issue Jul 11, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Refactor Refactoring is needed
Projects
None yet
Milestone
v1.2.0
2 participants
@samet-akcay @sahusiddharth