Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make imagenette path configurable in config #1832

Closed
holzweber opened this issue Mar 8, 2024 · 4 comments · Fixed by #1833
Closed

Make imagenette path configurable in config #1832

holzweber opened this issue Mar 8, 2024 · 4 comments · Fixed by #1833
Labels
Enhancement New feature or request Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.

Comments

@holzweber
Copy link
Contributor

imagenet_dir = Path("./datasets/imagenette")

@samet-akcay samet-akcay added Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute. Enhancement New feature or request labels Mar 8, 2024
@sahusiddharth
Copy link
Contributor

How would you prefer to configure the imagenette path? Would you like to use a structured format like YAML or JSON? or would you prefer a simpler approach where the path is provided directly as an argument?

@samet-akcay
Copy link
Contributor

samet-akcay commented Mar 8, 2024

Would it be an idea to have it as an argument here, like imagenette_path: Path | str ?

def __init__(
self,
teacher_out_channels: int = 384,
model_size: EfficientAdModelSize = EfficientAdModelSize.S,
lr: float = 0.0001,
weight_decay: float = 0.00001,
padding: bool = False,
pad_maps: bool = True,
batch_size: int = 1,
) -> None:

@sahusiddharth
Copy link
Contributor

Got it. I will also set the default path to ./datasets/imagenette, which won't break any existing test cases.

@holzweber
Copy link
Contributor Author

hey sorry for the late response
@samet-akcay showed exactly the idea i had how to solve this. thanks for the quick fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Issues that can be picked up by someone unfamiliar with the repo and would like to contribute.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants