Skip to content

Commit e045a0d

Browse files
committed
Improve error messaging
1 parent 6157533 commit e045a0d

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/graph_export/graph_export.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,9 @@ static Status createTextGenerationGraphTemplate(const std::string& directoryPath
9696
SPDLOG_TRACE("modelsPath: {}, directoryPath: {}, ggufFilename: {}", modelsPath, directoryPath, ggufFilename.value_or("std::nullopt"));
9797
auto pluginConfigOrStatus = GraphExport::createPluginString(graphSettings.pluginConfig, exportSettings);
9898
if (std::holds_alternative<Status>(pluginConfigOrStatus)) {
99-
return std::get<Status>(pluginConfigOrStatus);
99+
auto status = std::get<Status>(pluginConfigOrStatus);
100+
SPDLOG_ERROR("Failed to create plugin config: {}", status.string());
101+
return status;
100102
}
101103
// clang-format off
102104
oss << R"(
@@ -429,7 +431,7 @@ std::variant<std::string, Status> GraphExport::createPluginString(const PluginCo
429431
name.SetString(pluginConfig.kvCachePrecision.value().c_str(), d.GetAllocator());
430432
auto itr = d.FindMember("KV_CACHE_PRECISION");
431433
if (itr != d.MemberEnd()) {
432-
return StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS;
434+
return Status(StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS, "Doubled KV_CACHE_PRECISION parameter in plugin config.");
433435
}
434436
d.AddMember("KV_CACHE_PRECISION", name, d.GetAllocator());
435437
configNotEmpty = true;
@@ -440,7 +442,7 @@ std::variant<std::string, Status> GraphExport::createPluginString(const PluginCo
440442
value.SetUint(pluginConfig.maxPromptLength.value());
441443
auto itr = d.FindMember("MAX_PROMPT_LEN");
442444
if (itr != d.MemberEnd()) {
443-
return StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS;
445+
return Status(StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS, "Doubled MAX_PROMPT_LEN parameter in plugin config.");
444446
}
445447
d.AddMember("MAX_PROMPT_LEN", value, d.GetAllocator());
446448
configNotEmpty = true;
@@ -451,7 +453,7 @@ std::variant<std::string, Status> GraphExport::createPluginString(const PluginCo
451453
value.SetString(pluginConfig.modelDistributionPolicy.value().c_str(), d.GetAllocator());
452454
auto itr = d.FindMember("MODEL_DISTRIBUTION_POLICY");
453455
if (itr != d.MemberEnd()) {
454-
return StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS;
456+
return Status(StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS, "Doubled MODEL_DISTRIBUTION_POLICY parameter in plugin config.");
455457
}
456458
d.AddMember("MODEL_DISTRIBUTION_POLICY", value, d.GetAllocator());
457459
configNotEmpty = true;
@@ -461,7 +463,7 @@ std::variant<std::string, Status> GraphExport::createPluginString(const PluginCo
461463
value.SetString(exportSettings.cacheDir.value().c_str(), d.GetAllocator());
462464
auto itr = d.FindMember("CACHE_DIR");
463465
if (itr != d.MemberEnd()) {
464-
return StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS;
466+
return Status(StatusCode::PLUGIN_CONFIG_CONFLICTING_PARAMETERS, "Doubled CACHE_DIR parameter in plugin config.");
465467
}
466468
d.AddMember("CACHE_DIR", value, d.GetAllocator());
467469
configNotEmpty = true;

0 commit comments

Comments
 (0)