Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat template, add test for chat scenario #473

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Fix chat template, add test for chat scenario #473

merged 4 commits into from
Jul 4, 2024

Conversation

olpipi
Copy link
Collaborator

@olpipi olpipi commented Jun 5, 2024 •
edited
Loading

Fix chat template, add test for chat scenario

@github-actions github-actions bot added the category: llm_bench Label for tool/llm_bench folder label Jun 5, 2024
@olpipi olpipi force-pushed the chat_template branch 9 times, most recently from 85a5d95 to d817784 Compare June 10, 2024 08:54
@Wovchena
Copy link
Collaborator

Retarget to https://github.com/openvinotoolkit/openvino.genai/tree/releases/2024/2

@olpipi olpipi force-pushed the chat_template branch 2 times, most recently from 984a01a to 5159b56 Compare June 10, 2024 11:47
@olpipi olpipi changed the title PR to test chat scenario Fix chat template, add test for chat scenario Jun 10, 2024
@peterchen-intel peterchen-intel removed the category: llm_bench Label for tool/llm_bench folder label Jun 24, 2024
@olpipi olpipi requested review from Wovchena and pavel-esir and removed request for Wovchena July 1, 2024 17:27
Wovchena
Wovchena requested changes Jul 1, 2024
View reviewed changes
.github/workflows/causal_lm_cpp.yml Outdated Show resolved Hide resolved
.github/workflows/causal_lm_cpp.yml Outdated Show resolved Hide resolved
.github/workflows/causal_lm_cpp.yml Outdated Show resolved Hide resolved
.github/workflows/causal_lm_cpp.yml Outdated Show resolved Hide resolved
.github/workflows/causal_lm_cpp.yml Outdated Show resolved Hide resolved
src/cpp/src/llm_pipeline.cpp Show resolved Hide resolved
src/cpp/src/llm_pipeline.cpp Show resolved Hide resolved
@olpipi olpipi requested a review from Wovchena July 2, 2024 10:28
@olpipi olpipi force-pushed the chat_template branch 2 times, most recently from c508b7d to 5b90029 Compare July 2, 2024 14:44
pavel-esir
pavel-esir approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. As in understand it's left only to add and explanation to comments. Approve in advance

@olpipi olpipi requested a review from pavel-esir July 3, 2024 13:58
@Wovchena Wovchena enabled auto-merge July 3, 2024 14:13
auto-merge was automatically disabled July 3, 2024 14:14

Head branch was pushed to by a user without write access

@olpipi
Copy link
Collaborator Author

olpipi commented Jul 3, 2024

@Wovchena please enabled auto-merge again. I updated comment once more. Unfortunately, I don't have permission to do it myself

@Wovchena Wovchena enabled auto-merge July 3, 2024 14:16
@Wovchena Wovchena disabled auto-merge July 4, 2024 06:42
@Wovchena
Copy link
Collaborator

Wovchena commented Jul 4, 2024

build_jenkins

@Wovchena Wovchena enabled auto-merge July 4, 2024 06:42
@Wovchena Wovchena added this pull request to the merge queue Jul 4, 2024
Merged via the queue into openvinotoolkit:master with commit 08154fa Jul 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena approved these changes

@pavel-esir pavel-esir Awaiting requested review from pavel-esir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olpipi @Wovchena @pavel-esir @peterchen-intel