Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arguments to be passed to the CLI #422

Closed
JeffreyDevloo opened this issue Jan 19, 2018 · 5 comments
Closed

Allow arguments to be passed to the CLI #422

JeffreyDevloo opened this issue Jan 19, 2018 · 5 comments
Assignees
@JeffreyDevloo
Labels
type_feature
Milestone
M

Comments

@JeffreyDevloo
Copy link
Contributor

Feature description

Certain healthcheck methods are parameterized internally. To connect these variables to the CLI, we'd need something new
@JeffreyDevloo
Copy link
Contributor Author

JeffreyDevloo commented Jan 19, 2018 •
edited
Loading

Could resolve #421

@wimpers
Copy link

wimpers commented Mar 14, 2018 •
edited
Loading

Can we do the following:

  • Store all configurable parameters in the config arakoon as single json.
  • On startup the healthcheck get the config from the config arakoon.

Do you see any cons with this approach @JeffreyDevloo ?

@wimpers
Copy link

wimpers commented Mar 14, 2018

Estimated at 2d.

@wimpers wimpers mentioned this issue Apr 23, 2018
Closed
@JeffreyDevloo JeffreyDevloo self-assigned this Apr 24, 2018
@wimpers wimpers added this to the M milestone Apr 26, 2018
@JeffreyDevloo
Copy link
Contributor Author

Fixed by #447
Packaged in: openvstorage-health-check_3.7.0-dev.1525250711.8ba3b6b-1_amd64.deb

@JeffreyDevloo
Copy link
Contributor Author

Released in https://github.com/openvstorage/openvstorage-health-check/releases/tag/3.7.0
Packaged in openvstorage-health-check_3.7.0-1_amd64.deb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffreyDevloo JeffreyDevloo

Labels
type_feature
Projects
None yet
Milestone
M
Development

No branches or pull requests
2 participants
@wimpers @JeffreyDevloo