-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calcuate sd_hash in kb JWT #117
feat: calcuate sd_hash in kb JWT #117
Conversation
Signed-off-by: Lukas <Lukas@hopae.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #117 +/- ##
==========================================
- Coverage 95.54% 95.51% -0.04%
==========================================
Files 21 21
Lines 1705 1760 +55
Branches 246 253 +7
==========================================
+ Hits 1629 1681 +52
- Misses 72 75 +3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lukas <Lukas@hopae.io>
Signed-off-by: Lukas <Lukas@hopae.io>
@lukasjhan changes are looking good. Just fix the linting error and the PR is ready to be merged |
Signed-off-by: Lukas <Lukas@hopae.io>
3027b33
to
aaf9823
Compare
I changed it :), I think my vscode has some kind of bug. It changed the indent automatically but not show the diff XD |
A test for |
Okay I'll add one :) |
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
@cre8 Deleted it because it was an unused function. It was my mistake. :) |
hmm.. 0.04% |
Signed-off-by: Lukas <Lukas@hopae.io> Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Lukas <Lukas@hopae.io> Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
sd_hash is a base64url hash digest of the presented SD-JWT. So we can calculate that value in our logic.
It closes #108