-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make _digest value public in disclosure #151
feat: make _digest value public in disclosure #151
Conversation
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #151 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 23 23
Lines 1983 1991 +8
Branches 284 284
=======================================
+ Hits 1938 1946 +8
Misses 45 45 ☔ View full report in Codecov by Sentry. |
Hmm.. It's strange. biome success in local env |
Same for me. Running biome ci . or pnpm run format or lint locally is fine.... |
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@lukasjhan found the error: Changes were applied via biome directly and not manually. Since all tests passed it should be fine |
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
I referenced the biome call to the package json to make sure we got the same versions and therefore the same behavior local and in the ci. |
@cre8 Thank you :) |
Signed-off-by: Lukas.J.Han <lukas.j.han@gmail.com> Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de> Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
I made _digest value in disclosure as public.
When implementing features in holder side, usually we decode the disclosures and make a logic. In this situation we normally have _digest value, not need to calculate. So delivering hasher to get _digest value is not necessary.
It closes #150