Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sd-jwt-vc): improve alignment with draft-03 #175

Conversation

charsleysa
Copy link
Contributor

Improves alignment with draft 03

  • iat is no longer required
  • iat can now be selective disclosed
  • the header.typ value is now vc+sd-jwt

Copy link
Contributor

@cre8 cre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution @charsleysa

Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (d097f8c) to head (8bd3e54).

❗ Current head 8bd3e54 differs from pull request most recent head 29f0728. Consider uploading reports for the commit 29f0728 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   98.03%   98.02%   -0.01%     
==========================================
  Files          23       23              
  Lines        2082     2081       -1     
  Branches      307      307              
==========================================
- Hits         2041     2040       -1     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasjhan
Copy link
Member

@charsleysa Can you fix the lint failing on ci?

Run pnpm run format will fix the issue

@charsleysa charsleysa force-pushed the fix-sd-jwt-vc-improve-alignment branch from 4573d8e to 8bd3e54 Compare March 13, 2024 11:32
Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
@charsleysa charsleysa force-pushed the fix-sd-jwt-vc-improve-alignment branch from 8bd3e54 to 29f0728 Compare March 13, 2024 11:35
@charsleysa
Copy link
Contributor Author

@lukasjhan fixed!

@lukasjhan lukasjhan merged commit bcd7d6e into openwallet-foundation:main Mar 13, 2024
8 checks passed
@charsleysa charsleysa deleted the fix-sd-jwt-vc-improve-alignment branch March 13, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants