-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sd-jwt-vc): improve alignment with draft-03 #175
fix(sd-jwt-vc): improve alignment with draft-03 #175
Conversation
2daf4c3
to
4573d8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution @charsleysa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 98.03% 98.02% -0.01%
==========================================
Files 23 23
Lines 2082 2081 -1
Branches 307 307
==========================================
- Hits 2041 2040 -1
Misses 41 41 ☔ View full report in Codecov by Sentry. |
@charsleysa Can you fix the lint failing on ci? Run |
4573d8e
to
8bd3e54
Compare
Signed-off-by: Stefan Charsley <charsleysa@gmail.com>
8bd3e54
to
29f0728
Compare
@lukasjhan fixed! |
Improves alignment with draft 03