Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci publish action #89

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Feb 23, 2024

closes: #44

Updates the used variables so the action runs.

@lukasjhan
we need to define what is the "primary" branch. Veramo has this logic:

  • next is defined as the "default" branch where everything is merged. A commit to this branch will make a release for "next".
  • main is the branch holding the latest release. The difference between next and main is that not for every PR a new version is generated, but Authors are able to decide when it's time to create a new release on github (and to publish a new release version on npmjs). This will also set the :latest version on npmjs.
  • unstable: allows to push a version to npmjs for testing. It is not required to be first pushed to unstable, then to next and then to main. I am not quite sure if we need this stage. Maybe we can remove it in the future

This approach allows to have a tested version approach (because when we saw some bug on the next release, we can overwrite it in an easy way). On the other hand it's still the classic approach for the user because he can use latest or no version number during the installation to make sure he gets the latest released version.

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (01f02d1) to head (5ac4853).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          21       21           
  Lines        1514     1514           
  Branches      229      229           
=======================================
  Hits         1394     1394           
  Misses        113      113           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukasjhan
lukasjhan previously approved these changes Feb 23, 2024
@lukasjhan
Copy link
Member

@cre8 How about managing with main, release, unstable?

@lukasjhan
Copy link
Member

@cre8 How about managing with main, release, unstable?

I thought changing the default branch would be tricky, so I thought I'd just make the default branch "main".
But I think your point is reasonable. next means next lastest candidate.
Let's use next branch as you proposed 🙂

@lukasjhan
Copy link
Member

Let's merge it after default branch is changed.

@cre8
Copy link
Contributor Author

cre8 commented Feb 23, 2024

Keeping this PR open until #91 is done to avoid conflicts

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@cre8
Copy link
Contributor Author

cre8 commented Feb 23, 2024

@lukasjhan I added the settings file that should set the default branch to next. we are also able to define other rules in this file so #91 can be closed with this PR

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@cre8 cre8 requested a review from lukasjhan February 23, 2024 11:18
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Can we merge it? @cre8

@cre8
Copy link
Contributor Author

cre8 commented Feb 23, 2024

@lukasjhan I think so

@lukasjhan lukasjhan merged commit 8f9a4e0 into openwallet-foundation:main Feb 23, 2024
8 checks passed
@cre8 cre8 deleted the feat/ci branch February 23, 2024 14:24
@cre8
Copy link
Contributor Author

cre8 commented Feb 23, 2024

@lukasjhan I had to open another PR to add the --no-private step

cre8 added a commit to cre8/sd-jwt-js that referenced this pull request Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
cre8 added a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Co-authored-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CD for npm publish
2 participants