Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On upgrade to 0.7.4, multiwallet tokens don't work without iat #1889

Closed
TheTechmage opened this issue Aug 8, 2022 · 2 comments
Closed

On upgrade to 0.7.4, multiwallet tokens don't work without iat #1889

TheTechmage opened this issue Aug 8, 2022 · 2 comments

Comments

@TheTechmage
Copy link
Contributor

For jwt tokens that have been created without the iat field, they will no longer be considered valid and the profile cannot be retrieved. The offending code is located here:
https://github.com/hyperledger/aries-cloudagent-python/blob/dbe0f09e2c89d2da2da744d1d751da0dd40498ad/aries_cloudagent/multitenant/base.py#L395-L411

This commit should resolve the issue, however. I believe that it goes against the spirit of the original code.

@swcurran
Copy link
Contributor

swcurran commented Aug 8, 2022

Let's talk about this on the ACA-Pug call tomorrow. I'd like to understand the importance of this -- sounds bad...

@swcurran
Copy link
Contributor

This was discussed at the ACA-Pug meeting, and it was pointed out that this was expected behaviour as part of this change -- PR #1725 comment.

Debatable whether this is a breaking change, but we've added a warning to the Changelog for 0.7.4.

The proposed change (above) would remove the impact of the #1725 change, which is not helpful.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants