Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutOfBand events not exposed properly #1150

Closed
morrieinmaas opened this issue Dec 10, 2022 · 0 comments · Fixed by #1151
Closed

OutOfBand events not exposed properly #1150

morrieinmaas opened this issue Dec 10, 2022 · 0 comments · Fixed by #1151

Comments

@morrieinmaas
Copy link
Contributor

OutOfBandEvents are not exposed correctly.

For instance, one can import ConnectionStateChangedEvent from @aries-fromework/core whereas OutOfBandStateChangedEvent needs to be imported via import type { OutOfBandStateChangedEvent } from '@aries-framework/core/build/modules/oob/domain/OutOfBandEvents'. Additionally, this is annoying because the language server doesn't pick this up for autocompletion.

OUTCOME:
OutOfBandStateChangedEvent can be imported via import type {OutOfBandStateChangedEvent} from '@aries-framework/core'

Will submit fix myself. Issue just for doc purpose and have PR against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant